Entity registry doesn't overwrite with None #24275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jun 3, 2019
| @@ -127,8 +127,8 @@ def async_get_or_create(self, domain, platform, unique_id, *, | |||
| if entity_id: | |||
| return self._async_update_entity( | |||
| entity_id, | |||
| config_entry_id=config_entry_id, | |||
| device_id=device_id, | |||
| config_entry_id=config_entry_id or _UNDEF, | |||
There was a problem hiding this comment.
I think the better solution is to use _UNDEF instead of None as the default value.
There was a problem hiding this comment.
There was some reason why I didn't, I can't really remember why though. Will double check.
There was a problem hiding this comment.
I think what it came down to was that if you made _UNDEF the default instead of None, then further down when you're calling the RegistryEntry constructor you'd have to use something like None if device_id is _UNDEF else device_id.
There was a problem hiding this comment.
I think it's good to go.
balloob
approved these changes
Sep 4, 2019
pgilad
added a commit
to pgilad/home-assistant
that referenced
this pull request
Sep 4, 2019
* dev: (87 commits) Add atome sensor platform (home-assistant#26197) Replaces IOError by OSError (home-assistant#26428) Entity registry doesn't overwrite with None (home-assistant#24275) Add device to mqtt camera (home-assistant#26238) Updated frontend to 20190904.0 (home-assistant#26421) Add prettier to vscode (home-assistant#26417) NSW Rural Fire Service icon for geolocation entities (home-assistant#26416) Update azure-pipelines-translation.yml for Azure Pipelines [ci skip] Translation update Update azure-pipelines-translation.yml for Azure Pipelines Update azure-pipelines-translation.yml for Azure Pipelines Update azure-pipelines-translation.yml for Azure Pipelines Update azure-pipelines-translation.yml for Azure Pipelines Bumped version to 0.98.3 Bump ISY994's PyISY dependency to 1.1.2 (home-assistant#26413) Fix state report (home-assistant#26406) Update to 0.1.13 (home-assistant#26402) Met, check for existing location (home-assistant#26400) Allow core config updated (home-assistant#26398) Fix race during initial Sonos group construction (home-assistant#26371) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Little patch to entity registry.
Checklist:
tox. Your PR cannot be merged unless tests pass