deCONZ - proper comparison of discovered and conf 10000 igured gateways #24378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hue has a similar thing https://github.com/home-assistant/home-assistant/blob/f77514c6f284a7d9b59e667bb97478acb3318cf8/homeassistant/components/hue/config_flow.py#L166-L170 I want to release 94.1 now, and since this is draft, will untag it from 94.1. It can go in 94.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
Apparently the bridgeid differ between what is received from UPnP discovery and deCONZ Rest API. This change compares the UPnP UUID instead.
I am awaiting feedback from deCONZ developers if there is a way to compare the bridgeid instead, as to minimise this fix as much as possible. dresden-elektronik/deconz-rest-plugin#1575
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: