8000 Fix Alexa Report State by balloob · Pull Request #26305 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Alexa Report State #26305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2019
Merged

Fix Alexa Report State #26305

merged 2 commits into from
Aug 31, 2019

Conversation

balloob
Copy link
Member
@balloob balloob commented Aug 30, 2019 •
edited
Loading

Description:

Fix invalid tokens being used to report states to Alexa and fix the "has expired" check.

Fixes #26289

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.98.2 milestone Aug 30, 2019
@balloob balloob force-pushed the fix-alexa-report-state branch from d7e8a1b to 46f8e02 Compare August 30, 2019 23:41
andrewsayre
andrewsayre approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member
@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewsayre andrewsayre merged commit 7b05ede into dev Aug 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-alexa-report-state branch August 31, 2019 01:34
@lock lock bot locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewsayre andrewsayre andrewsayre approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core has-tests integration: alexa integration: cloud
Projects
None yet
Milestone
0.98.2
Development

Successfully merging this pull request may close these issues.

Alexa Report State can get a stale token.
3 participants
@balloob @andrewsayre @homeassistant
0