8000 Fix connection issues with withings API by switching to a maintained codebase by vangorra · Pull Request #27310 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix connection issues with withings API by switching to a maintained codebase #27310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2019
Merged

Fix connection issues with withings API by switching to a maintained codebase #27310

merged 3 commits into from
Oct 8, 2019

Conversation

vangorra
Copy link
Contributor
@vangorra vangorra commented Oct 8, 2019

Breaking Change:

No breaking changes.

Description:

Shortly after inclusion into home assistant, the withings API started requiring extra data when authorizing. The client code the withings component uses was maintained. So we have switched over to a maintained api client.

Related issue (if applicable): fixes #
fixes #26716

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@balloob
Copy link
Member
balloob commented Oct 8, 2019

Ok to merge when you run script/gen_requirements_all.py

@MartinHjelmare MartinHjelmare changed the title Fixing connection issues with withings API by switching to a maintained codebase Fix connection issues with withings API by switching to a maintained codebase Oct 8, 2019
MartinHjelmare
MartinHjelmare reviewed Oct 8, 2019
View reviewed changes
MartinHjelmare
MartinHjelmare approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 0714763 into home-assistant:dev Oct 8, 2019
@MartinHjelmare
Copy link
Member

Should this go into 0.100?

@vangorra
Copy link
Contributor Author
vangorra commented Oct 8, 2019

Yes

@balloob balloob added this to the 0.100 milestone Oct 8, 2019
@lock lock bot locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed Hacktoberfest has-tests integration: withings small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.100
Development

Successfully merging this pull request may close these issues.

Can't authorise Withings
5 participants
@vangorra @balloob @MartinHjelmare @bramkragten @homeassistant
0