8000 Withings fix by vangorra · Pull Request #27404 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Withings fix #27404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 10, 2019
Merged

Withings fix #27404

merged 6 commits into from
Oct 10, 2019

Conversation

vangorra
Copy link
Contributor

Breaking Change:

No breaking changes.

Description:

  • withings-api==2.0.0b8 uses static version number in setup.py, so it should not cause issues with the release scripts.
  • Shortly after inclusion into home assistant, the withings API started requiring extra data when authorizing. The client code the withings component uses was maintained. So we have switched over to a maintained api client.

Related issue (if applicable): fixes #26716

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@balloob
Copy link
Member
balloob commented Oct 10, 2019

Please rebase.

@vangorra vangorra mentioned this pull request Oct 10, 2019
Closed
@vangorra
Merge branch 'dev' into vangorra_withings_fix
8ba2f8a 
# Conflicts:
#	requirements_test_all.txt
#	script/gen_requirements_all.py
@vangorra
Updating requirements files.
cf66835
@balloob balloob added this to the 0.100.2 milestone Oct 10, 2019
@balloob balloob merged commit 77490a3 into home-assistant:dev Oct 10, 2019
@lock lock bot locked and limited conversation to collaborators Oct 11, 2019
@balloob balloob changed the title Vangorra withings fix Withings fix Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed Hacktoberfest has-tests integration: withings small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.100.2
Development

Successfully merging this pull request may close these issues.

Can't authorise Withings
3 participants
@vangorra @balloob @homeassistant
0