Use voluptuous for dweet, transmission, and twitch senso 8000 r #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| vol.Required(CONF_DEVICE): cv.string, | ||
| vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string, | ||
| vol.Optional(CONF_UNIT_OF_MEASUREMENT): cv.string, | ||
| vol.Optional(CONF_VALUE_TEMPLATE): cv.template, |
There was a problem hiding this comment.
Based on the diff, it seems like value template was required but is now optional. Is this intentional?
There was a problem hiding this comment.
No, I was just careless. Thanks.
|
Looks good 🐬 can merge when comments addressed. |
|
The requirements build failed because the two platforms try to import constants that do not exist in |
| @@ -53,18 +69,17 @@ def setup_platform(hass, config, add_devices, discovery_info=None): | |||
| transmission_api.session_stats) | |||
|
|
|||
| dev = [] | |||
| for variable in config['monitored_variables']: | |||
| for variable in config[CONF_MONITORED_VARIABLES]: | |||
| if variable not in SENSOR_TYPES: | |||
There was a problem hiding this comment.
Can be removed with validation 👍
|
Looks good! 🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying sug
2E8A
gestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes 127528299
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices, web services, or a:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass