8000 Add voluptuous to wemo. by pavoni · Pull Request #2895 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add voluptuous to wemo. #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2016
Merged

Add voluptuous to wemo. #2895

merged 1 commit into from
Aug 20, 2016

Conversation

pavoni
Copy link
Contributor
@pavoni pavoni commented Aug 19, 2016

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices, web services, or a:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@fabaff fabaff mentioned this pull request Aug 19, 2016
@fabaff
Copy link
Member
fabaff commented Aug 20, 2016

Looks good to me.

@fabaff fabaff merged commit 482f32b into dev Aug 20, 2016
@pavoni pavoni deleted the wemo_voluptuous branch August 20, 2016 14:33
technicalpickles added a commit to technicalpickles/home-assistant that referenced this pull request Aug 28, 2016
This was reported in https://community.home-assistant.io/t/issue-after-update/3339/4

home-assistant#2895 added
voluptuous to wemo, but in the process it removed defaulting static
to an empty array.
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0