8000 Use voluptuous for OhmConnect by fabaff · Pull Request #2906 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use voluptuous for OhmConnect #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2016
Merged

Use voluptuous for OhmConnect #2906

merged 2 commits into from
Aug 22, 2016

Conversation

fabaff
Copy link
Member
@fabaff fabaff commented Aug 20, 2016

Description:
Migration of the configuration check of the OhmConnect sensor to voluptuous.

Related issue (if applicable): fixes 127528299

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

sensor:
  platform: ohmconnect
  id: AbCd1e

@robbiet480 , would be nice if you could take a look at the changes.

@fabaff fabaff mentioned this pull request Aug 20, 2016
Closed
balloob
balloob reviewed Aug 20, 2016
View reviewed changes
homeassistant/components/sensor/ohmconnect.py
@@ -51,7 +61,7 @@ def state(self):
if self._data.get("active") == "True":
return "Active"
else:
return "Inactive"
return "Inactive" "OhmConnect Status"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, looks like a copy-&-paste error.

@robbiet480
Copy link
Member

@fabaff This looks good!

@fabaff fabaff merged commit 5d816b5 into home-assistant:dev Aug 22, 2016
@fabaff fabaff deleted the voluptuous-ohm branch August 22, 2016 06:20
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @robbiet480 @balloob
0