Google assistant storage of connected agents #29158
Conversation
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
cbd28be to
20fa575
Compare
9b45727 to
12817cf
Compare
|
Nice, this pull is starting to look quite clean now. Do we need an upgrade function? The store will be empty for upgrading users. A user that have already connected would need to relink, issue a sync by refreshing in google home, explicitly do a sync request from HA. I think that is enough to mention in release notes. |
Instead pass along cloud_user where appropriate.
| def async_schedule_google_sync_all(self): | ||
| """Schedule a sync for all registered agents.""" | ||
| for agent_user_id in self._store.agent_user_ids: | ||
| self.async_schedule_google_sync(agent_user_id) |
There was a problem hiding this comment.
We don't have to keep async_schedule_google_sync around, we will never want a single sync to be done ? Probably same for a bunch of other methods that involve a single action instead of doing it for all connected users
There was a problem hiding this comment.
nevermind, realize now that the per-agent-user-id methods are implemented by the implementations and not the base class.
Description:
This adds support for remembering which user agent have connected to your home assistance instance and gives support for disconnect calls as well as separate listed entities for different users.
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: