Inline MQTT paho imports #29177
Inline MQTT paho imports #29177
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
|
Maybe we should explicitly add This gives us the hint it was meant intentionally and makes enabling the rule in the future much easier. |
|
We may need to move this line too: |
|
Done & Done! |
|
Done! |
|
Not sure if the better fix is to install also after_dependencies requirements. On docker, we have also most packages preinstall without getting an issue. Now the mqtt after_dependencies work, but we need to make a list which integration can be an after_dependencies and there is no warranty that we don't run into the same issue on integration with different after_dependencies. This PR feels not like a real bug fix. I can't approve this PR. |
|
Yeah, it's not optimal. |
|
We install The camera integration has I want to go ahead and merge this, so that OwnTracks and MySensors can be used again. We can come up with a better solution in the future. |
Description:
Some integrations rely optionally on MQTT (ie. OwnTracks, MySensors). These could no longer be imported because the MQTT imports would fail (
mqttis only an after_dependencies).Related issue (if applicable): fixes #28464
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: