8000 Fix somfy switch inherit from SwitchDevice instead of ToggleEntity by tetienne · Pull Request #29182 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix somfy switch inherit from SwitchDevice instead of ToggleEntity 8000 #29182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2019
Merged

Fix somfy switch inherit from SwitchDevice instead of ToggleEntity #29182

merged 1 commit into from
Nov 29, 2019

Conversation

tetienne
Copy link
Contributor
@tetienne tetienne commented Nov 28, 2019 •
edited
Loading

Description:

See #29057 (review)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@tetienne tetienne mentioned this pull request Nov 28, 2019
Merged
7 tasks
@MartinHjelmare MartinHjelmare changed the title FIX Inherit from SwitchDevice instead of ToggleEntity Fix somfy switch inherit from SwitchDevice instead of ToggleEntity Nov 28, 2019
MartinHjelmare
MartinHjelmare approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@tetienne
Copy link
Contributor Author

@MartinHjelmare Anyway to trigger another build? The error is not linked to my code:

unable to access 'https://gitlab.com/pycqa/flake8

@frenck
Copy link
Member
frenck commented Nov 29, 2019

Retriggered it

@MartinHjelmare MartinHjelmare merged commit 12155cb into home-assistant:dev Nov 29, 2019
@lock lock bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: somfy small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tetienne @MartinHjelmare @frenck @homeassistant
0