Improve Alexa interface selection for binary 8000 sensors #29120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the sensor to work correctly as a contact or motion sensor in alexa, if the user overrides its display category as such.
|
Hey there @home-assistant/cloud, @ochlocracy, mind taking a look at this pull request as its been labeled with a integration ( |
|
In what scenario does the entity not have the right device class? That seems like a bug in the integration. |
|
@balloob Lets say you have a leak sensor, that has the correct device class. If I want to be able to use it in Alexa I would need to force it into the CONTACT_SENSOR or MOTION_SENSOR display_category. |
…into alexa_binary_sensors
|
I see. that's fine for now. Ok to merge when docs PR linked. |
balloob
approved these changes
Dec 2, 2019
|
@balloob what docs? The display categories were already documented previously, they were just not working properly (the sensor would appear with the correct type in alexa, but with an error). |
|
ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This allows the sensor to work correctly as a contact or motion sensor in alexa, if the user overrides its display category as such.
Without this, if the user sets a binary sensor display category to CONTACT_SENSOR, for example, Alexa will show an error for that device, unless the binary sensor HA display_class is door.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: