Add alexa check for "name" channelMetadata attr 8000 ibute #29279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/cloud, @ochlocracy, mind taking a look at this pull request as its been labeled with a integration ( |
|
Thanks for this. I assume we also need a test case in: https://github.com/home-assistant/home-assistant/blob/dev/tests/components/alexa/test_smart_home.py |
|
I did not add a test case for such a small change but will if the powers
that be suggest I do :)
…On Sat, Nov 30, 2019 at 10:21 PM Bruno Filipe ***@***.***> wrote:
Thanks for this. I assume we also need a test case in:
https://github.com/home-assistant/home-assistant/blob/dev/tests/components/alexa/test_smart_home.py
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29279>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABW4E7OD7HB27L3A4OMHMXLQWMUU3ANCNFSM4JTJPLSA>
.
|
8000
|
I will need to add the test. It looks for it. Ok, I will add it and re-pull
…On Sat, Nov 30, 2019 at 10:29 PM Alain Turbide ***@***.***> wrote:
I did not add a test case for such a small change but will if the powers
that be suggest I do :)
On Sat, Nov 30, 2019 at 10:21 PM Bruno Filipe ***@***.***>
wrote:
> Thanks for this. I assume we also need a test case in:
> https://github.com/home-assistant/home-assistant/blob/dev/tests/components/alexa/test_smart_home.py
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#29279>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABW4E7OD7HB27L3A4OMHMXLQWMUU3ANCNFSM4JTJPLSA>
> .
>
|
…hanelMetadata payload section
|
Looks good 👍 |
…response, returning "name" is not technically valid. Modified to return the value in the callSign field instead since it's a text value. Since there is no returned channel number, cannot return a true numeric value in "channel" field
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
None
Description:
Add a check for "name" channelMetadata attribute, This attribute will be used as the default channel name to send to the media_player when no channel number is found. This attribute gets filled when the user says Alexa, tune to "<channelname>"
Related issue (if applicable): fixes #29274
`
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: