Use voluptuous for statsd #2928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM ! |
Closed
| vol.Optional(CONF_PREFIX, default=DEFAULT_PREFIX): cv.string, | ||
| vol.Optional(CONF_RATE, default=DEFAULT_RATE): | ||
| vol.All(vol.Coerce(int), vol.Range(min=1)), | ||
| }), |
There was a problem hiding this comment.
Disallow inside component schema.
|
StatsD tests are broken. |
hartmms
pushed a commit
to hartmms/home-assistant
that referenced
this pull request
Sep 17, 2016
* Migrate to voluptuous * Update tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Migration of the configuration check to
voluptuous.Related issue (if applicable): fixes 127528299
Example entry for
configuration.yaml(if applicable):@michaelkuty, would be nice if you could take a look at the changes and run a quick test. Thanks.