8000 Remove cloud dependency from mobile_app by balloob · Pull Request #29373 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove cloud dependency from mobile_app #29373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2019
Merged

Remove cloud dependency from mobile_app #29373

merged 1 commit into from
Dec 3, 2019

Conversation

balloob
Copy link
Member
@balloob balloob commented Dec 3, 2019 •
edited
Loading

Breaking Change:

Loading Mobile App no longer causes Cloud integration to be loaded. If you relied on this, add cloud: to your configuration.yaml.

Description:

Guard all calls into cloud integration from mobile_app.

@MartinHjelmare @pvizeli I guess here too, we could just install after_dependencies and it's not a problem 🤷‍♂

Related issue (if applicable): Fixes #29347

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@balloob balloob requested a review from robbiet480 as a code owner December 3, 2019 22:00
@probot-home-assistant
Copy link

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (mobile_app) you are listed as a codeowner for? Thanks!

robbiet480
robbiet480 approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member
@robbiet480 robbiet480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MartinHjelmare
MartinHjelmare approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would change if we used after_dependencies?

@balloob
Copy link
Member Author
balloob commented Dec 3, 2019

This is a similar issue to the OwnTracks <> MQTT one. If we would add cloud to after_dependencies here and we install those requirements as @pvizeli suggested, we wouldn't have to do these checks.

I am starting to lean to that solution btw.

@balloob balloob merged commit e26eebf into dev Dec 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-mobile-app-cloud-dep branch December 3, 2019 23:43
@pvizeli
Copy link
Member
pvizeli commented Dec 4, 2019 •
edited
Loading

add cloud to after_dependencies

I'm fine with that. Other integration can also use cloudhooks and to check all time is cloud loaded or not end up in the issue that we forget a check and it fails. So we would have less complexity and less possible errors.

@balloob balloob mentioned this pull request Dec 4, 2019
Merged
5 tasks
@lock lock bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robbiet480 robbiet480 robbiet480 approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@robbiet480 robbiet480

Labels
breaking-change cla-signed core integration: mobile_app small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home Assistant Cloud is disabled but configuration entry is still visible
5 participants
@balloob @pvizeli @robbiet480 @MartinHjelmare @homeassistant
0