8000 Add name option to season sensor by springstan · Pull Request #29302 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add name option to season sensor #29302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2019
Merged

Add name option to season sensor #29302

merged 2 commits into from
Dec 2, 2019

Conversation

springstan
Copy link
Member
@springstan springstan commented Dec 1, 2019 •
edited
Loading

Breaking Change:

Description:

  • add name option to the season sensor so that users can modify its name to their liking

Related issue (if applicable): fixes #29298

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11346<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

  - platform: season
    type: astronomical
    name: myastronomicalsensor
  - platform: season
    type: meteorological
    name: mymeteorologicalsensor

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant probot-home-assistant bot added integration: season small-pr PRs with less than 30 lines. labels Dec 1, 2019
@springstan springstan mentioned this pull request Dec 1, 2019
Merged
2 tasks
@Mariusthvdb
Copy link
Contributor

tyvm!
really appreciated.

@springstan
Copy link
Member Author

@Mariusthvdb of course! No problem at all.

@fabaff fabaff merged commit b28bc1d into home-assistant:dev Dec 2, 2019
@lock lock bot locked and limited conversation to collaborators Dec 3, 2019
@springstan springstan deleted the add-config-name-option-season-sensor branch December 16, 2019 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
cla-signed integration: season small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sensor season has no name option
4 participants
@springstan @Mariusthvdb @fabaff @homeassistant
0