10000 Use voluptuous for Splunk by fabaff · Pull Request #2931 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use voluptuous for Splunk #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2016
Merged

Use voluptuous for Splunk #2931

merged 2 commits into from
Aug 24, 2016

Conversation

fabaff
Copy link
Member
@fabaff fabaff commented Aug 22, 2016

Description:
Migration of the configuration check to voluptuous.

Related issue (if applicable): fixes 127528299

Example entry for configuration.yaml (if applicable):

splunk:
  host: SPLUNK_HOST_IP_ADDRESS_OR_HOST_NAME
  port: 8088
  token: B4415DFF-683C-5C6C-3994-4F6D4A5DB03A
  SSL: True

@miniconfig, would be nice if you could take a look at the changes and run a quick test. Thanks.

@fabaff fabaff mentioned this pull request Aug 22, 2016
Closed
balloob
balloob reviewed Aug 23, 2016
View reviewed changes
homeassistant/components/splunk.py
vol.Optional(CONF_HOST, default=DEFAULT_HOST): cv.string,
vol.Optional(CONF_PORT, default=DEFAULT_PORT): cv.port,
vol.Optional(CONF_SSL, default=False): cv.boolean,
}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disallow extra

@balloob balloob merged commit 6f27d58 into home-assistant:dev Aug 24, 2016
@fabaff fabaff deleted the voluptuous-splunk branch August 24, 2016 07:05
@miniconfig
Copy link
Contributor

Sorry for the delay, but I finally got a chance to test and this works fine. Thanks!

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @miniconfig @balloob
0