8000 Switch iperf3 to generate a new client every time it runs a test by rohankapoorcom · Pull Request #29495 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Switch iperf3 to generate a new client every time it runs a test #29495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2019
Merged

Switch iperf3 to generate a new client every time it runs a test #29495

merged 3 commits into from
Dec 5, 2019

Conversation

rohankapoorcom
Copy link
Member
@rohankapoorcom rohankapoorcom commented Dec 5, 2019 •
edited
Loading

Description:

Generates a new Iperf3 client every time one is needed, rather than re-using the existing one. There is a race condition in the existing implementation because both the upload/download sensors start updating at the same time using the same client. Rather than saving and reusing two unique clients, it seems better to regenerate when we need to use one. Thanks to @dooz127 for tracing down the root cause.

I also added myself to CODEOWNERS for iperf3 since I have been maintaining it.

Related issue (if applicable): fixes #22163

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

iperf3:
  hosts:
    - host: bouygues.iperf.fr
  monitored_conditions:
    - download
    - upload

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant probot-home-assistant bot added integration: iperf3 small-pr PRs with less than 30 lines. labels Dec 5, 2019
@balloob balloob merged commit b2d5de6 into home-assistant:dev Dec 5, 2019
@dooz127
Copy link
dooz127 commented Dec 5, 2019

Awesome. Works when I manually call the service and my latest update.

@rohankapoorcom rohankapoorcom deleted the fix-iperf3 branch December 5, 2019 07:10
@lock lock bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed integration: iperf3 small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iperf3 not working: unable to send cookie
4 participants
@rohankapoorcom @dooz127 @balloob @homeassistant
0