10000 Use voluptuous for APCUPSd by fabaff · Pull Request #2954 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use voluptuous for APCUPSd #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2016
Merged

Use voluptuous for APCUPSd #2954

merged 1 commit into from
Aug 30, 2016

Conversation

fabaff
Copy link
Member
@fabaff fabaff commented Aug 24, 2016 •
edited
Loading

Description:
Migration of the configuration check to voluptuous.

Related issue (if applicable): fixes 127528299

Example entry for configuration.yaml (if applicable):

apcupsd:
  host: IP_ADDRESS
  port: PORT

@flyte @dale3h , would be nice if you could take a look at the changes and run a quick test. Thanks.

@fabaff fabaff mentioned this pull request Aug 24, 2016
Closed
@fabaff fabaff changed the title Migrate to voluptuous Use voluptuous for APCUPSd Aug 24, 2016
@robbiet480
Copy link
Member

@flyte @dale3h We are releasing 0.27 in about 16 hours from when I am writing this comment. It would be great to see more goodies like this make it in. Can you confirm the changes are okay by testing it?

Thanks!

@flyte
Copy link
Contributor
flyte commented Aug 27, 2016

Hey guys, voluptuous looks cool. I'd love to check it out but I won't be afforded any time to "play on my computer" this weekend. I'll certainly have a look during the week though if it's still required.

@dale3h
Copy link
Member
dale3h commented Aug 27, 2016

@fabaff binary_sensor and sensor are good to go. I don't have APCUPSd network daemon setup, so I am unable to test the component.

@Teagan42
Copy link
Contributor

LGTM 🐬

@fabaff fabaff merged commit eec96ea into home-assistant:dev Aug 30, 2016
@fabaff fabaff deleted the voluptuous-apcupsd branch August 30, 2016 19:34
@robbiet480 robbiet480 mentioned this pull request Aug 30, 2016
Merged
@Danielhiversen Danielhiversen mentioned this pull request Aug 31, 2016
Merged
8 tasks
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabaff @robbiet480 @flyte @dale3h @Teagan42
0