8000 Fix neato device info by Santobert · Pull Request #29570 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix neato device info #29570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix neato device info #29570

merged 1 commit into from
Dec 9, 2019

Conversation

Santobert
Copy link
Member

Breaking Change:

Maybe there are some minor changes since we use other sources to fill in device_info. But I can't imagine a use-case that could be broken by this change.

Description:

An endpoint of neao's API broke some time ago. There is a workaround where the error is caught (#29156). Now we use a different endpoint to fetch device information. We are now using get_general_info() instead of get_robot_info() as the last one is intended for debugging purposes.

Please include this in the next release once it has been accepted.

Related issue (if applicable): fixes #29239

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@probot-home-assistant probot-home-assistant bot added integration: neato small-pr PRs with less than 30 lines. labels Dec 6, 2019
@probot-home-assistant
Copy link

Hey there @dshokouhi, mind taking a look at this pull request as its been labeled with a integration (neato) you are listed as a codeowner for? Thanks!

@Santobert Santobert changed the title Change source of device_info Fix neato device info Dec 6, 2019
dshokouhi
dshokouhi approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member
@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

cgtobi
cgtobi approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor
@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Santobert Santobert added this to the 0.103.0 milestone Dec 7, 2019
@Santobert
Copy link
Member Author

I've tagged this for 0.103.0. Please remove this tag again, if this is not allowed.

@balloob balloob merged commit c399fe2 into home-assistant:dev Dec 9, 2019
@Santobert Santobert deleted the fix_neato_device_info branch December 9, 2019 19:06
balloob pushed a commit that referenced this pull request Dec 10, 2019
@Santobert @balloob
Change source of device_info (#29570)
90de565
@lock lock bot locked and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgtobi cgtobi cgtobi approved these changes

@dshokouhi dshokouhi dshokouhi approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed integration: neato small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.103.0
Development

Successfully merging this pull request may close these issues.

Sudden neato connection error no Vacuum entity created
5 participants
@Santobert @cgtobi @dshokouhi @balloob @homeassistant
0