8000 Use voluptuous for Mjpeg and generic camera by fabaff · Pull Request #2989 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use voluptuous for Mjpeg and generic camera #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2016
Merged

Use voluptuous for Mjpeg and generic camera #2989

merged 1 commit into from
Aug 27, 2016

Conversation

fabaff
Copy link
Member
@fabaff fabaff commented Aug 26, 2016

Description:
Migration of the configuration check to voluptuous.

Related issue (if applicable): fixes 127528299

Example entry for configuration.yaml (if applicable):

camera:
  platform: mjpeg
  mjpeg_url: http://192.168.1.92/mjpeg
  name: my sample camera
  username: USERNAME
  password: PASSWORD
  authentication: basic

@fabaff fabaff mentioned this pull request Aug 26, 2016
Closed
Teagan42
Teagan42 reviewed Aug 26, 2016
View reviewed changes
8000
homeassistant/components/camera/generic.py
_LOGGER = logging.getLogger(__name__)

BASIC_AUTHENTICATION = 'basic'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see these two authentication methods abstracted to const.py - both camera platforms are using the same constants

@Teagan42
Copy link
Contributor

🐬 Unless you feel like moving those strings to const.py

@fabaff
Copy link
Member Author
fabaff commented Aug 26, 2016 •
edited
Loading

Will be fixed soon...I meant the removal of the additional commits.

@robbiet480 robbiet480 changed the title Use voluptuous for Mjpeg and gerneric camera Use voluptuous for Mjpeg and generic camera Aug 27, 2016
@Teagan42 Teagan42 merged commit e6b9d5f into home-assistant:dev Aug 27, 2016
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
@fabaff fabaff deleted the voluptuous-cameras branch April 12, 2017 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabaff @Teagan42
0