8000 Bump Roku to 4.0.0 by bwarden · Pull Request #29809 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump Roku to 4.0.0 8000 #29809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

Bump Roku to 4.0.0 #29809

merged 1 commit into from
Dec 10, 2019

Conversation

bwarden
Copy link
Contributor
@bwarden bwarden commented Dec 9, 2019 •
edited
Loading

Description:

Bump python-roku dependency to take advantage of new method mentioned in #29123, implemented in jcarbaugh/python-roku#52 and released in version 4.0.0.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare MartinHjelmare mentioned this pull request Dec 10, 2019
Closed
4 tasks
@pvizeli pvizeli merged commit 9049e09 into home-assistant:dev Dec 10, 2019
@pvizeli pvizeli added this to the 0.103.0 milestone Dec 10, 2019
balloob pushed a commit that referenced this pull request Dec 10, 2019
@bwarden @balloob
Bump Roku to 4.0.0 (#29809)
807bade
@springstan springstan mentioned this pull request Dec 10, 2019
Closed
@lock lock bot locked and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-picked cla-signed dependency integration: roku small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.103.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bwarden @balloob @pvizeli @homeassistant
0