Voluptuous for AsusWRT #2998
Merged
Voluptuous for AsusWRT #2998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| vol.Required(CONF_HOST): cv.string, | ||
| vol.Required(CONF_USERNAME): cv.string, | ||
| vol.Optional(CONF_PASSWORD): cv.string, | ||
| vol.Optional(CONF_PROTOCOL, default='ssh'): vol.Schema(['ssh', 'telnet']), 8000 |
There was a problem hiding this comment.
- 80: E501 line too long (82 > 79 characters)
Closed
| @@ -1,14 +1,34 @@ | |||
| """The tests for the ASUSWRT device tracker platform.""" | |||
|
|
|||
| # pylint: disable=invalid-name | |||
There was a problem hiding this comment.
What are we disabling exactly? If possible can you move the pylint disable to the specific line(s), because if it's here at the top of the file it will apply to everything in it.
|
Move the pylint then 🐬 |
| from homeassistant.util import Throttle | ||
| import homeassistant.helpers.config_validation as cv | ||
| from homeassistant.components.device_tracker import PLATFORM_SCHEMA |
There was a problem hiding this comment.
Can be merged with from homeassistant.components.device_tracker import DOMAIN.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add Voluptuous for Asus WRT
Example entry for
configuration.yaml(if applicable):Checklist:
If code communicates with devices, web services, or a:
toxrun successfully. Your PR cannot be merged unless tests pass