8000 Add unique ID to ONVIF camera entities by frenck · Pull Request #32093 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add unique ID to ONVIF camera entities #32093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2020
Merged

Add unique ID to ONVIF camera entities #32093

merged 1 commit into from
Feb 22, 2020

Conversation

frenck
Copy link
Member
@frenck frenck commented Feb 22, 2020 •
edited
Loading

Proposed change

Add a unique ID to ONVIF camera entities (if available), based on the MAC address of the active network interface of a camera.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
camera:
  - platform: onvif
    name: my_camera
    host: 192.168.1.2
    port: 8000
    username: admin
    password: admin

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added integration: onvif small-pr PRs with less than 30 lines. labels Feb 22, 2020
@codecov
Copy link
codecov bot commented Feb 22, 2020

Codecov Report

Merging #32093 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32093   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         767      767           
  Lines       55479    55479           
=======================================
  Hits        52552    52552           
  Misses       2927     2927
Impacted Files Coverage Δ
homeassistant/helpers/entity.py 97.27% <0.00%> (-0.35%) ⬇️
homeassistant/components/uk_transport/sensor.py 94.20% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced870c...93f6e97. Read the comment docs.

springstan
springstan approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member
@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Kane610
Kane610 approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member
@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@springstan springstan merged commit edfb967 into dev Feb 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the frenck-2020-0226 branch February 22, 2020 21:29
@lock lock bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kane610 Kane610 Kane610 approved these changes

@springstan springstan springstan approved these changes

Assignees
No one assigned
Labels
cla-signed integration: onvif small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frenck @Kane610 @springstan @homeassistant
0