8000 Use voluptuous for netatmo by fabaff · Pull Request #3287 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use voluptuous for netatmo #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2016
Merged

Use voluptuous for netatmo #3287

merged 2 commits into from
Sep 11, 2016

Conversation

fabaff
Copy link
Member
@fabaff fabaff commented Sep 9, 2016

Description:
Migration of the configuration check to voluptuous.

Related issue (if applicable): fixes 127528299

Example entry for configuration.yaml (if applicable):

netatmo:
  api_key: YOUR_API_KEY
  secret_key: YOUR_SECRET_KEY
  username: YOUR_USERNAME
  password: YOUR_PASSWORD

sensor:
  platform: netatmo
  station: STATION_NAME
  modules:
    module_name1:
      - temperature
    module_name2:
      - temperature

@jabesq, would be nice if you could take a look at the changes and run a quick test. Thanks.

@fabaff fabaff mentioned this pull request Sep 9, 2016
Closed
@fabaff fabaff closed this Sep 9, 2016
@fabaff fabaff reopened this Sep 9, 2016
@jabesq
Copy link
Contributor
jabesq commented Sep 9, 2016 •
edited
Loading

No problem to do a quick test, just ping once the Travis CI build is OK

@fabaff fabaff closed this Sep 9, 2016
@fabaff fabaff reopened this Sep 9, 2016
balloob
balloob reviewed Sep 10, 2016
View reviewed changes
homeassistant/components/netatmo.py

REQUIREMENTS = [
'https://github.com/jabesq/netatmo-api-python/archive/'
'master.zip#lnetatmo==0.5.0']
# 'v0.5.0.zip#lnetatmo==0.5.0']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hoped that the archives are back.

philippelt/netatmo-api-python#7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archive is back as requested in #2233.

@balloob
Copy link
Member
balloob commented Sep 10, 2016

🐬 when comments addressed

@fabaff fabaff merged commit 515c477 into home-assistant:dev Sep 11, 2016
@fabaff fabaff deleted the voluptuous-netatmo branch September 11, 2016 19:28
@jabesq
Copy link
Contributor
jabesq commented Sep 16, 2016

Sorry to reopen this topic, I just tested it and this is not working because in the configuration module_name1, module_name2 are placeholders for the name of the modules. I'll do a quick fix in my PR that will come this weekend by changing:

vol.Required(CONF_MODULE_NAME, default=[]):

into

vol.Required(cv.string, default=[])

@jabesq jabesq mentioned this pull request Sep 26, 2016
Merged
6 tasks
@balloob balloob mentioned this pull request Sep 29, 2016
Closed
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
voluptuous
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @jabesq @balloob
0