8000 Tankerkoenig UUIDs are not UUIDv4 by guillempages · Pull Request #33121 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tankerkoenig UUIDs are not UUIDv4 #33121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Tankerkoenig UUIDs are not UUIDv4 #33121

wants to merge 1 commit into from

Conversation

guillempages
Copy link
Contributor
@guillempages guillempages commented Mar 21, 2020 •
edited
Loading

Breaking change

Proposed change

Validate against generic UUIDs, not requiring v4 UUIDs

It turns out, that the UUIDs used by the tankerkoenig.de site are not using v4; so forcing the validator to UUIDv4 might break the integration for some users. Validating against generic UUIDs (no specific version) fixes the issue.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
tankerkoenig:
  api_key: my-key
  fuel_types: 
    - diesel
  radius: 5
  scan_interval: "0:10:00"

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@guillempages guillempages mentioned this pull request Mar 21, 2020
Merged
@guillempages
Copy link
Contributor Author

@balloob this fixes the UUIDv4 issue for tankerkoenig.

balloob
balloob reviewed Mar 21, 2020
View reviewed changes
homeassistant/components/tankerkoenig/__init__.py
@@ -27,16 +27,16 @@
DEFAULT_SCAN_INTERVAL = timedelta(minutes=30)


def uuid4_string(value):
"""Validate a v4 UUID in string format."""
def uuid_string(value):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why even validate it as uuid at all ?

@guillempages
Copy link
Contributor Author

Removed the whole validation code.

@guillempages guillempages deleted the tankerkoenig branch March 22, 2020 00:02
@lock lock bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob 575C balloob left review comments

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: tankerkoenig small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillempages @balloob @homeassistant
0