8000 Fix velbus dimming control by brefra · Pull Request #33139 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix velbus dimming control #33139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2020
Merged

Fix velbus dimming control #33139

merged 2 commits into from
Mar 24, 2020

Conversation

brefra
Copy link
Contributor
@brefra brefra commented Mar 22, 2020

Breaking change

None

Proposed change

Fixes dimmer control jumping back from 100% to 40% due to sending wrong dimmer value range.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

n/a

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added integration: velbus small-pr PRs with less than 30 lines. labels Mar 22, 2020
@probot-home-assistant
Copy link

Hey there @cereal2nd, mind taking a look at this pull request as its been labeled with a integration (velbus) you are listed as a codeowner for? Thanks!

@cereal2nd
Copy link
Contributor

👍

MartinHjelmare
MartinHjelmare reviewed Mar 24, 2020
View reviewed changes
@MartinHjelmare MartinHjelmare changed the title Fix dimming control Fix velbus dimming control Mar 24, 2020
@brefra brefra requested a review from MartinHjelmare March 24, 2020 20:10
MartinHjelmare
MartinHjelmare approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 0.107.7 milestone Mar 24, 2020
@MartinHjelmare MartinHjelmare merged commit 46985bb into home-assistant:dev Mar 24, 2020
@brefra brefra deleted the fix-velbus-dimming branch March 24, 2020 21:06
balloob pushed a commit that referenced this pull request Mar 25, 2020
@brefra @balloob
Fix velbus dimming control (#33139)
9365ba3 
* Fix light control

* Optimize conversion logic
@balloob balloob mentioned this pull request Mar 25, 2020
Merged
@lock lock bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed integration: velbus small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.107.7
Development

Successfully merging this pull request may close these issues.

Velbus dimmer jumps back from 100% to 40%
5 participants
@brefra @cereal2nd @MartinHjelmare @balloob @homeassistant
0