8000 Schedule Unifi shutdown callback earlier by jjlawren · Pull Request #33257 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Schedule Unifi shutdown callback earlier #33257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2020
Merged

Schedule Unifi shutdown callback earlier #33257

merged 1 commit into from
Mar 25, 2020

Conversation

jjlawren
Copy link
Contributor

Proposed change

If the Unifi controller host isn't available in its clients list it will abort too early and skip scheduling the HA shutdown callback, leading to errors during shutdown.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added integration: unifi small-pr PRs with less than 30 lines. labels Mar 25, 2020
@jjlawren jjlawren requested a review from Kane610 March 25, 2020 20:19
@probot-home-assistant
Copy link

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (unifi) you are listed as a codeowner for? Thanks!

@balloob balloob added this to the 0.107.7 milestone Mar 25, 2020
Kane610
Kane610 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member
@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@balloob balloob merged commit 5650b39 into home-assistant:dev Mar 25, 2020
balloob pushed a commit that referenced this pull request Mar 25, 2020
@jjlawren @balloob
Schedule Unifi shutdown callback earlier (#33257)
a38e075
@balloob balloob mentioned this pull request Mar 25, 2020
Merged
@jjlawren jjlawren deleted the unifi_missing_controller branch March 26, 2020 15:25
@lock lock bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kane610 Kane610 Kane610 approved these changes

Assignees

@Kane610 Kane610

Labels
cherry-picked cla-signed integration: unifi small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.107.7
Development

Successfully merging this pull request may close these issues.

Unifi: Dispatch errors on shutdown
4 participants
@jjlawren @Kane610 @balloob @homeassistant
0