8000 TTS: Wait till files are created in tests by balloob · Pull Request #33760 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TTS: Wait till files are created in tests #33760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

TTS: Wait till files are created in tests #33760

merged 1 commit into from
Apr 6, 2020

Conversation

balloob
Copy link
Member
@balloob balloob commented Apr 6, 2020

Breaking change

Proposed change

It looks like we hit a race condition where TTS files are not written to disk yet. That is solved now.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @pvizeli, mind taking a look at this pull request as its been labeled with a integration (tts) you are listed as a codeowner for? Thanks!

@springstan springstan mentioned this pull request Apr 6, 2020
Merged
20 tasks
@codecov

This comment has been minimized.

Sign in to view
@balloob balloob merged commit cc1564d into dev Apr 6, 2020
@balloob balloob deleted the fix-flaky-tts branch April 6, 2020 22:11
@balloob balloob added this to the 0.108.1 milestone Apr 9, 2020
balloob added a commit that referenced this pull request Apr 9, 2020
@balloob
TTS: Wait till files are created in tests (#33760)
0528921
@balloob balloob mentioned this pull request Apr 9, 2020
Merged
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pvizeli pvizeli

Labels
cherry-picked cla-signed core has-tests integration: tts small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.108.1
Development

Successfully merging this pull request may close these issues.
3 participants
@balloob @pvizeli @homeassistant
0