8000 Fix octoprint sensor error message rendering by danbishop · Pull Request #33788 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix octoprint sensor error message rendering #33788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fix octoprint sensor error message rendering #33788

merged 1 commit into from
Apr 8, 2020

Conversation

danbishop
Copy link
Contributor
@danbishop danbishop commented Apr 7, 2020 •
edited by MartinHjelmare
Loading

Proposed change

Fix error message rendering. Add missing semi-colons to html entities on notification message.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@danbishop
Update sensor.py
5110241 
Add missing semi-colons to html entities on notification message
@homeassistant
Copy link
Contributor

Hi @danbishop,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added integration: octoprint small-pr PRs with less than 30 lines. labels Apr 7, 2020
@MartinHjelmare MartinHjelmare changed the title Update sensor.py Update octoprint sensor Apr 8, 2020
@MartinHjelmare MartinHjelmare changed the title Update octoprint sensor Fix octoprint sensor error message rendering Apr 8, 2020
@bachya bachya added this to the 0.108.1 milestone Apr 8, 2020
@bachya bachya merged commit 292dcb7 into home-assistant:dev Apr 8, 2020
balloob pushed a commit that referenced this pull request Apr 9, 2020
@danbishop @balloob
Update sensor.py (#33788)
49db0a3 
Add missing semi-colons to html entities on notification message
@balloob balloob mentioned this pull request Apr 9, 2020
Merged
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed integration: octoprint small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.108.1
Development

Successfully merging this pull request may close these issues.
5 participants
@danbishop @homeassistant @MartinHjelmare @bachya @balloob
0