8000 Update to pyipp==0.9.1 by ctalkington · Pull Request #33819 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update to pyipp==0.9.1 #33819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

Update to pyipp==0.9.1 #33819

merged 1 commit into from
Apr 8, 2020

Conversation

ctalkington
Copy link
Contributor

Proposed change

Based on reported issues, this version includes fixes for languages other than EN and now raises an IPPParseError if converting the data has a type error due to varying standards. Marker levels are also better type checked to prevent issues where marker data isnt available but the attribute is provided.

This SHOULD be included in 108 for UX reasons.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@frenck frenck added this to the 0.108.1 milestone Apr 8, 2020
@ctalkington
Copy link
Contributor Author

test failure seems unrelated

@MartinHjelmare
Copy link
Member

Please rebase on latest dev branch to let the build pass. We've merged a fix for the missing library.

@springstan springstan changed the title Update to pyipp==0.9.1 Bump pyipp to 0.9.1 Apr 8, 2020
@balloob balloob changed the title Bump pyipp to 0.9.1 Update to pyipp==0.9.1 Apr 8, 2020
@balloob balloob merged commit d032489 into home-assistant:dev Apr 8, 2020
@ctalkington ctalkington deleted the ipp091 branch April 9, 2020 02:34
balloob pushed a commit that referenced this pull request Apr 9, 2020
@ctalkington @balloob
Update to pyipp==0.9.1 (#33819)
da8ce07
@balloob balloob mentioned this pull request Apr 9, 2020
Merged
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@springstan springstan springstan approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked dependency integration: ipp small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.108.1
Development

Successfully merging this pull request may close these issues.

IPP - TypeError: 'int' object is not subscriptable (BETA)
5 participants
@ctalkington @MartinHjelmare @springstan @frenck @balloob
0