8000 Fix kef DSP_SCAN_INTERVAL timedelta by basnijholt · Pull Request #33825 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix 8000 kef DSP_SCAN_INTERVAL timedelta #33825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fix kef DSP_SCAN_INTERVAL timedelta #33825

merged 1 commit into from
Apr 8, 2020

Conversation

basnijholt
Copy link
Contributor

Proposed change

Fixes the broken state in 0.108.0 reported on https://community.home-assistant.io/t/kef-ls50-wireless/70269/134!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob added this to the 0.108.1 milestone Apr 8, 2020
@MartinHjelmare MartinHjelmare changed the title make DSP_SCAN_INTERVAL a timedelta, fixes the broken state Fix kef DSP_SCAN_INTERVAL timedelta Apr 8, 2020
@basnijholt
Copy link
Contributor Author
basnijholt commented Apr 8, 2020 •
edited
Loading

The failing linting test is unrelated.

This is fixed by #33828.

@basnijholt basnijholt force-pushed the kef-fix-scan-interval branch from 9257dd6 to 7619a85 Compare April 8, 2020 19:13
@balloob balloob merged commit ceb1719 into home-assistant:dev Apr 8, 2020
balloob pushed a commit that referenced this pull request Apr 9, 2020
@basnijholt @balloob
Fix kef DSP_SCAN_INTERVAL timedelta (#33825)
885cf20 
reported on https://community.home-assistant.io/t/kef-ls50-wireless/70269/134
@balloob balloob mentioned this pull request Apr 9, 2020
Merged
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed integration: kef small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.108.1
Development

Successfully merging this pull request may close these issues.
3 participants
@basnijholt @balloob @homeassistant
0