8000 Add opentherm_gw.set_hot_water_setpoint service by mvn23 · Pull Request #34579 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add opentherm_gw.set_hot_water_setpoint service #34579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2020
Merged

Add opentherm_gw.set_hot_water_setpoint service #34579

merged 1 commit into from
Jun 12, 2020

Conversation

mvn23
Copy link
Contributor
@mvn23 mvn23 commented Apr 23, 2020 •
edited
Loading

Proposed change

Add opentherm_gw.set_hot_water_setpoint service. This allows us to change the domestic hot water target temperature on boilers that support this feature.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@mvn23 mvn23 mentioned this pull request Apr 23, 2020
Merged
8 tasks
@stale
Copy link
stale bot commented Jun 3, 2020

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Jun 3, 2020
@mvn23
Copy link
Contributor Author
mvn23 commented Jun 3, 2020

Still waiting for reviews...

@stale stale bot removed the stale label Jun 3, 2020
MartinHjelmare
MartinHjelmare approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 15113ae into home-assistant:dev Jun 12, 2020
@yotuze
Copy link
yotuze commented Jul 20, 2020

I just found this after HA update. I'm ready to test, just tell me what you want to know. For know I can't change DHW temperature using opentherm_gw.set_hot_water_setpoint. Nothing change, I use De Dietrich Boiler with nodo-gateway.

@mvn23
Copy link
Contributor Author
mvn23 commented Jul 20, 2020

I just found this after HA update. I'm ready to test, just tell me what you want to know. For know I can't change DHW temperature using opentherm_gw.set_hot_water_setpoint. Nothing change, I use De Dietrich Boiler with nodo-gateway.

If you believe you have found a bug in Home Assistant, please file a bug report through the proper channels. Before doing so, please make sure that it is an actual bug in Home Assistant, i.e. that it does work when you manually change the hot water setpoint through serial commands or with otmonitor.

@mvn23 mvn23 deleted the otgw_dhw_setp branch July 20, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: opentherm_gw new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenThermGateway no service to set DHW temp and heating curve
5 participants
@mvn23 @yotuze @MartinHjelmare @balloob @homeassistant
0