8000 Hue: Guard for when there is no brightness by balloob · Pull Request #35151 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hue: Guard for when there is no brightness #35151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2020
Merged

Hue: Guard for when there is no brightness #35151

merged 1 commit into from
May 3, 2020

Conversation

balloob
Copy link
Member
@balloob balloob commented May 3, 2020

Breaking change

Proposed change

Hue would break if lights had no brightness.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@cgarwood cgarwood merged commit 5b7daa9 into dev May 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the guard-no-brightness branch May 3, 2020 23:21
@balloob balloob added this to the 0.109.4 milestone May 4, 2020
balloob added a commit that referenced this pull request May 5, 2020
@balloob
Hue: Guard for when there is no brightness (#35151)
0d8390b
@balloob balloob mentioned this pull request May 5, 2020
Merged
@lock lock bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: hue small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.109.4
Development

Successfully merging this pull request may close these issues.

Error Message if you Toggle Hue Light from UI and iOS Compagnion App
4 participants
@balloob @frenck @cgarwood @homeassistant
0