8000 Fix utility_meter calibration with float values by dgomes · Pull Request #35186 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix utility_meter calibration with float values #35186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2020
Merged

Fix utility_meter calibration with float values #35186

merged 4 commits into from
May 5, 2020

Conversation

dgomes
Copy link
Contributor
@dgomes dgomes commented May 4, 2020

Breaking change

Proposed change

Calibrate with the value after rouding and having the exponent of the current state

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

utility_meter:
  daily_water:
    source: sensor.raskhod_vody_v_min
    cycle: daily
  monthly_water:
    source: sensor.raskhod_vody_v_min
    cycle: monthly
    offset:
      days: +26
      hours: 0
      minutes: 0

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@dgomes dgomes added this to the 0.109.4 milestone May 4, 2020
@MartinHjelmare MartinHjelmare changed the title Fixes utility_meter calibration with float values Fix utility_meter calibration with float values May 5, 2020
@MartinHjelmare MartinHjelmare merged commit 53c1aba into home-assistant:dev May 5, 2020
balloob pushed a commit that referenced this pull request May 5, 2020
@dgomes @balloob
Fix utility_meter calibration with float values (#35186)
96576a9
@balloob balloob mentioned this pull request May 5, 2020
Merged
@BobbyBleacher
Copy link

Also fixes #33574

@lock lock bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: utility_meter small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.109.4
Development

Successfully merging this pull request may close these issues.

Utility-Meter service_calibrate value precision problem
5 participants
@dgomes @BobbyBleacher @MartinHjelmare @balloob @homeassistant
0