Monkey-patch a weakref set in Task to be a no-op. #3639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Task.all_tasks() is no longer accurate, and there will be no | ||
| warning emitted if a Task is GC'd while in use. | ||
|
|
||
| On Python 3.6, after the bug is fixed, this monkey-patch can be |
There was a problem hiding this comment.
Does this have any bad side effects if it's still applied to 3.6? As long as 3.4 is supported, this would be needed, and I suspect that would be awhile because 3.4 is the latest on raspbian.
If that's the case, can it dynamically be only applied to python 3.4 and 3.5?
There was a problem hiding this comment.
The bug is still open for 3.6 - we hope it will get fixed by 3.6.
There was a problem hiding this comment.
Not really, I just noted it there in case anyone wanted to know when it should hopefully be fixed.
|
Code looks good 🐬 . Just some linting errors to address. |
|
Don't fix them btw, as it makes no sense to fix them. Just disable them: # pylint: disable=no-self-use, too-few-public-methods, protected-access
# pylint: disable=bare-except, wrong-import-order |
balloob
pushed a commit
that referenced
this pull request
Oct 1, 2016
* Monkey-patch a weakref set in Task to be a no-op. * Fix linting issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Monkey-patches the asyncio.tasks.Task object to remove its weakref.WeakSet and
__del__method. These were both involved in causing seg-faults due to a Python bug (https://bugs.python.org/issue26617) that may not be addressed in a shipping Python for some time. The side-effect is that the Task.all_tasks() method will no longer work. If code relies on that method (nothing does that I've found thus far) then it will be inaccurate and throw an exception as the replacement object does not implement__iter__.Related issue (if applicable): fixes #3453
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass