8000 Refactor ZHA Entity availability tracking by Adminiuga · Pull Request #36645 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor ZHA Entity availability tracking #36645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 11, 2020
Merged

Refactor ZHA Entity availability tracking #36645

merged 6 commits into from
Jun 11, 2020

Conversation

Adminiuga
Copy link
Contributor
@Adminiuga Adminiuga commented Jun 11, 2020 •
edited
Loading

Breaking change

No

Proposed change

ZHA Entity availability tracks ZHADevice's availability. Upon restarts, set initial device availability based on when device was last seen (based on zha.storage)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

n/a

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Adminiuga Adminiuga requested a review from dmulcahey June 11, 2020 01:23
@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Adminiuga Adminiuga force-pushed the ac/zha-entity-avail branch from d3da283 to 7deeedc Compare June 11, 2020 19:29
@dmulcahey dmulcahey merged commit 21acdbb into home-assistant:dev Jun 11, 2020
@Adminiuga Adminiuga deleted the ac/zha-entity-avail branch June 12, 2020 14:23
@TheJulianJES TheJulianJES mentioned this pull request Mar 19, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmulcahey dmulcahey dmulcahey approved these changes

Assignees

@dmulcahey dmulcahey

@Adminiuga Adminiuga

Labels
cla-signed has-tests integration: zha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Adminiuga @dmulcahey @homeassistant
0