8000 Fix packages when config schema is fully deprecated by frenck · Pull Request #36674 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix packages when config schema is 8000 fully deprecated #36674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2020
Merged

Fix packages when config schema is fully deprecated #36674

merged 3 commits into from
Jun 11, 2020

Conversation

frenck
Copy link
Member
@frenck frenck commented Jun 11, 2020

Proposed change

The openuv integration introduced a schema being deprecated fully, implemented as:

CONFIG_SCHEMA = cv.deprecated(DOMAIN, invalidation_version="0.115")

However, with packages, it tries to the default value, which goes south since the schema is missing and the logic tried to determine if it is a list or dict we are dealing with here.

This PR adds a check and just returns the identified config schema as None.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added bugfix core small-pr PRs with less than 30 lines. labels Jun 11, 2020
balloob
balloob reviewed Jun 11, 2020
View reviewed changes
@balloob balloob added this to the 0.111.1 milestone Jun 11, 2020
frenck and others added 2 commits June 11, 2020 19:39
@frenck @balloob
Update homeassistant/config.py
8834e90 
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@frenck
Fix typing
ca1d971
@balloob
Copy link
Member
balloob commented Jun 11, 2020

Tested locally, tests pass.

@balloob balloob merged commit 0146f35 into dev Jun 11, 2020
@balloob balloob deleted the frenck-2020-0608 branch June 11, 2020 17:59
balloob added a commit that referenced this pull request Jun 11, 2020
@frenck @balloob
Fix packages when config schema is fully deprecated (#36674)
aac7cf1 
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@balloob balloob mentioned this pull request Jun 11, 2020
Merged
hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
@sdb9696
Change noteworthy tplink PR in 2025.1 release notes (home-assistant#3…
306be12 
…6674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.111.1
Development

Successfully merging this pull request may close these issues.

0.111.0: Upgrade from 0.110.7 fails
3 participants
@frenck @balloob @homeassistant
0