8000 Fix missing options in Plex config entry by jjlawren · Pull Request #36683 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix missing options in Plex config entry #36683< 8000 /span>

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fix missing options in Plex config entry #36683

merged 1 commit into from
Jun 11, 2020

Conversation

jjlawren
Copy link
Contributor

Proposed change

Integration would fail to start up if config options were not stored in the config entry.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@jjlawren jjlawren linked an issue Jun 11, 2020 that may be closed by this pull request
Plex integration throws an exception upon loading #36678
Closed
@jjlawren jjlawren added this to the 0.111.2 milestone Jun 11, 2020
@balloob balloob merged commit d4d2335 into home-assistant:dev Jun 11, 2020
bramkragten pushed a commit that referenced this pull request Jun 13, 2020
@jjlawren @bramkragten
Fix missing options in Plex config entry (#36683)
ad7edb4
@bramkragten bramkragten mentioned this pull request Jun 13, 2020
Merged
@jjlawren jjlawren deleted the plex_lost_options_dict branch June 15, 2020 14:53
hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
@googanhiem @frenck
Upload 3-2-1 backups blog (home-assistant#36683)
4029f1e 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: plex small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.111.2
Development

Successfully merging this pull request may close these issues.

Plex integration throws an exception upon loading PLEX: async_call when dispatching 'plex_update_platforms_signal
4 participants
@jjlawren @balloob @bramkragten @homeassistant
0