8000 Update config_entry_flow test test_user_has_confirmation by emontnemery · Pull Request #36633 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update config_entry_flow test tes 8000 t_user_has_confirmation #36633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2020
Merged

Update config_entry_flow test test_user_has_confirmation #36633

merged 2 commits into from
Jun 13, 2020

Conversation

emontnemery
Copy link
Contributor
@emontnemery emontnemery commented Jun 10, 2020 •
edited
Loading

Proposed change

Update config_entry_flow test test_user_has_confirmation

  • Fix stale docstring
  • Test that confirmation is required

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added code-quality core small-pr PRs with less than 30 lines. labels Jun 10, 2020
MartinHjelmare
MartinHjelmare reviewed Jun 10, 2020
View reviewed changes
@emontnemery emontnemery merged commit 922b332 into home-assistant:dev Jun 13, 2020
@emontnemery emontnemery deleted the config_entry_flow_update_test branch October 14, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @MartinHjelmare @homeassistant
0