8000 Fix history timezone with postgres and other dbs by bdraco · Pull Request #36746 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix history timezone with postgres and other dbs #36746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2020
Merged

Fix history timezone with postgres and other dbs #36746

merged 1 commit into from
Jun 13, 2020

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Jun 13, 2020 •
edited
Loading

Proposed change

Ensure timestamps are converted to utc for in-between history states.

Fixes home-assistant/frontend#6154

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco added this to the 0.111.2 milestone Jun 13, 2020
@bdraco
Copy link
Member Author
bdraco commented Jun 13, 2020 •
edited
Loading

I couldn't think of a good way to write a test this since we don't have a good way to spin up a test postgres instance with a non-utc timezone in the test and mocking this with an in-memory sqlite required changing the system time zone which seems like a "bad idea"

@bdraco bdraco added the bugfix label Jun 13, 2020
@bramkragten bramkragten merged commit 65e9e4a into home-assistant:dev Jun 13, 2020
bramkragten pushed a commit that referenced this pull request Jun 13, 2020
@bdraco @bramkragten
Fix history timezone with postgres and other dbs (#36746)
48b6f41
@bramkragten bramkragten mentioned this pull request Jun 13, 2020
Merged
@thecode thecode mentioned this pull request Jun 13, 2020
Closed
3 tasks
@bdraco bdraco mentioned this pull request Jun 13, 2020
Merged
20 tasks
@mirekmal
Copy link

I see the same issue on my system (HA running as VM in ESX server + MariaDB running as add-on on Synology NAS). However, besides not being able to display any history graphs, I also observed (using phpMyAdmin) that there is no new history recorded in DB since upgrade to 0.111.2. Is this the same issue (no new sates or events records in tables)?

@bdraco
Copy link
Member Author
bdraco commented Jun 14, 2020

I see the same issue on my system (HA running as VM in ESX server + MariaDB running as add-on on Synology NAS). However, besides not being able to display any history graphs, I also observed (using phpMyAdmin) that there is no new history recorded in DB since upgrade to 0.111.2. Is this the same issue (no new sates or events records in tables)?

If the fixed linked in home-assistant/frontend#6161 doesn't solve this, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bramkragten bramkragten bramkragten approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed core integration: history small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.111.2
Development

Successfully merging this pull request may close these issues.

All Charts in 0.111 have a timestamp gap
4 participants
@bdraco @mirekmal @bramkragten @homeassistant
0