8000 Fix OwnTracks race condition by balloob · Pull Request #37152 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix OwnTracks race condition #37152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2020
Merged

Fix OwnTracks race condition #37152

merged 1 commit into from
Jun 26, 2020

Conversation

balloob
Copy link
Member
@balloob balloob commented Jun 26, 2020

Breaking change

Proposed change

Since we made speedup faster, OwnTracks was able to hit a race condition where there were pending messages interfering with state restoration.

This PR fixes it.

Fixes #37124

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob added this to the 0.112.0 milestone Jun 26, 2020
@balloob balloob merged commit 50dd6b6 into dev Jun 26, 2020
@balloob balloob deleted the owntracks-race branch June 26, 2020 21:25
balloob added a commit that referenced this pull request Jun 26, 2020
@balloob
Fix OwnTracks race condition (#37152)
b9c233f
hahn-th pushed a commit to hahn-th/core that referenced this pull request May 2, 2025
@dontinelli
Update solarlog documentation (home-assistant#37152)
c9f8c20 
Add comment about firmware restrictions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed integration: owntracks small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.112.0
Development

Successfully merging this pull request may close these issues.

0.112.0b1 Platform owntracks does not generate unique IDs error
2 participants
@balloob @homeassistant
0