8000 Use voluptuous for Heatmiser by fabaff · Pull Request #3732 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use voluptuous for Heatmiser #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Use voluptuous for Heatmiser #3732

merged 1 commit into from
Oct 11, 2016

Conversation

fabaff
Copy link
Member
@fabaff fabaff commented Oct 6, 2016

Description:
Migration of the configuration check to voluptuous.

Related issue (if applicable): fixes 127528299

Example entry for configuration.yaml (if applicable):

climate:
  - platform: heatmiser
    ipaddress: 10.0.0.204
    port: 123
    tstats:
      1:
        id: 1xxx
        name: thermo1
      3:
        id: 2xxx
        name: thermo2

The docs were not clear how the tstats: should look like. This PR uses the same style for multiple entries as others do.

It would be preferred if somebody with Heatmiser hardware could test this change.

@mention-bot
Copy link

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @turbokongen to be a potential reviewer.

@fabaff fabaff mentioned this pull request Oct 6, 2016
@balloob balloob merged commit 0568ef0 into home-assistant:dev Oct 11, 2016
@MartinHjelmare
Copy link
Member

tstats used to be a list.

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
@fabaff fabaff deleted the voluptuous-heatmiser branch April 12, 2017 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0