Add option to retrieve n amount of last lines from log. #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbokongen
added a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Nov 12, 2017
fabaff
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Nov 12, 2017
* Update control-panel.markdown Info for home-assistant/frontend#604 * Update control-panel.markdown * Update control-panel.markdown
balloob
reviewed
Nov 14, 2017
panels/config/zwave/zwave-log.html
Outdated
| } else { | ||
| this.hass.callApi('GET', 'zwave/ozwlog') | ||
| .then((info) => { | ||
| var lines = info.split('\n'); |
There was a problem hiding this comment.
We should not limit log lines in the frontend but instead add support to the backend
c35b1f2 to
8605bb5
Compare
balloob
reviewed
Nov 15, 2017
panels/config/zwave/zwave-log.html
Outdated
| <paper-button raised on-tap='refreshLog'>Refresh</paper-button> | ||
| </div> | ||
| <div class='help-text'> | ||
| <template is='dom-repeat' items='[[ozwLogs]]' as='state'> |
There was a problem hiding this comment.
If you're going to create a <pre> tag per line, why even break it up per line at all on the backend ? Just return a text and just set that to a single <pre> tag.
|
You're still using a |
|
I've moved your lines parameter from url param to query param. That makes more sense. Please test it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the user choose to retrieve only n amount of last loglines. (Max=1000, min=0(equals the whole log) and step is 10)
