8000 Removes warning when `dataset` is configured without setting `service-name` by mjayaram · Pull Request #167 · honeycombio/buildevents · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Removes warning when dataset is configured without setting service-name #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2022
Merged

Removes warning when dataset is configured without setting service-name #167

merged 1 commit into from
Aug 24, 2022

Conversation

mjayaram
Copy link
Contributor
@mjayaram mjayaram commented Aug 24, 2022 •
edited
Loading

Which problem is this PR solving?

As part of introducing Environments and Services, we also support users of Buildevents to configure the service-name associated to Build Events. However, for Build Events, the configuration dataset is also still valid to allow users to name the bucket into which events from their pipelines and builds are sent to.

We are removing the "Warning" prompting users to change their dataset config to be called service name.

Short description of the changes

  • Remove the warning to change dataset to service name
  • Ensure we are setting a default value if no dataset or service name is set (configured)

@mjayaram
Removes checking and warning for when only the dataset is configured …
2cc03bb 
…for Buildevents; Updates logic to set default is no Dataset is configured for the non-classic use
@mjayaram mjayaram changed the title Removes checking and warning for when only the dataset is configured … Removes warning when dataset is configured without setting service-name Aug 24, 2022
@mjayaram mjayaram added type: enhancement New feature or request version: bump patch A PR with release-worthy changes and is backwards-compatible. merge at will Reviewer can merge the PR once reviewed. version: bump minor A PR that adds behavior, but is backwards-compatible. and removed version: bump minor A PR that adds behavior, but is backwards-compatible. labels Aug 24, 2022
@mjayaram mjayaram marked this pull request as ready for review August 24, 2022 17:15
@mjayaram mjayaram requested review from a team, robbkidd and kentquirk August 24, 2022 17:15
@mjayaram mjayaram merged commit b9e334d into main Aug 24, 2022
@mjayaram mjayaram deleted the mjayaram.removes-warning-for-dataset branch August 24, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@robbkidd robbkidd Awaiting requested review from robbkidd

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees
No one assigned
Labels
merge at will Reviewer can merge the PR once reviewed. type: enhancement New feature or request version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjayaram @MikeGoldsmith
0