8000 Include field `error` true for spans representing failure results by mjayaram · Pull Request #168 · honeycombio/buildevents · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Include field error true for spans representing failure results #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2022
Merged

Include field error true for spans representing failure results #168

merged 1 commit into from
Aug 25, 2022

Conversation

mjayaram
Copy link
Contributor
@mjayaram mjayaram commented Aug 25, 2022 •
edited
Loading

Which problem is this PR solving?

We noticed for Github Actions or even CircleCI buildevents that the step or command that represents the failure does not include the boolean field error set to true

We use this value to signal the error state in the UI:

Signaling which step(s) contains the error

AND in the calculation to display error rates on the Home page for Buildevents:

Home Page - Error rate

Short description of the changes

Includes the field error true along with sending status failed and failure reason for a span

@mjayaram mjayaram changed the title include sending error true for spans representing error states for bu… Include field error true for spans representing failure results Aug 25, 2022
@mjayaram mjayaram marked this pull request as ready for review August 25, 2022 01:01
@mjayaram mjayaram requested review from a team and emilyashley August 25, 2022 01:01
@mjayaram mjayaram added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. labels Aug 25, 2022
@mjayaram mjayaram merged commit 6761996 into main Aug 25, 2022
@mjayaram mjayaram deleted the mjayaram.mapping-error-true branch August 25, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@emilyashley emilyashley Awaiting requested review from emilyashley

Assignees
No one assigned
Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjayaram @MikeGoldsmith
0