feat(trace): update profileIDLabelName to match Pyroscope #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
Beelines are being sunset, so try hard not to change them unless we absolutely have to. Can you please add a little more text to the PR summary explaining the context and why this change is needed? This looks like a breaking change but after digging I can see that the spec changed a while back.
Sure thing. This is purely a change needed for internal purposes, if this helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We've switched to using Pyroscope OSS internally rather than Pyroscope/Grafana Cloud, so we need to use the format that the current profiling solution expects for how span names are tagged when doing correlation of span and profile signals.