8000 Add extra warnings to enabling STDOUT in non-production environments by MikeGoldsmith · Pull Request #134 · honeycombio/beeline-go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add extra warnings to enabling STDOUT in non-production environments #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2020
Merged

Add extra warnings to enabling STDOUT in non-production environments #134

merged 3 commits into from
Sep 2, 2020

Conversation

MikeGoldsmith
Copy link
Contributor
  • adds extra comments to examples to indicate setting STDOUT is not a good idea outside of dev
  • writes a log to stdout using fmt in yellow if config.STDOUT is set during beeline init

@MikeGoldsmith MikeGoldsmith requested a review from a team August 25, 2020 13:14
@MikeGoldsmith MikeGoldsmith merged commit 0137bca into main Sep 2, 2020
@MikeGoldsmith MikeGoldsmith deleted the mike/stdout-warnings branch September 2, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulosman paulosman paulosman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeGoldsmith @paulosman
0