8000 fix: make consumer package available by Yoshinaz · Pull Request #53 · honestbank/kp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make consumer package available #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to 8000 your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2022
Merged

fix: make consumer package available #53

merged 2 commits into from
Dec 9, 2022

Conversation

Yoshinaz
Copy link
Contributor
@Yoshinaz Yoshinaz commented Dec 8, 2022 •
edited
Loading

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to
    the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.

Description

  • move consumer package out from internal

This change is Reviewable

@Yoshinaz Yoshinaz requested a review from a team as a code owner December 8, 2022 09:25
@poom
Copy link
Contributor
poom commented Dec 8, 2022

@Yoshinaz check go-tests too

@cyberhck
Copy link
Contributor
cyberhck commented Dec 9, 2022

update the tests too.

@sonarqubecloud
Copy link
sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.7% 94.7% Coverage
0.0% 0.0% Duplication

@Yoshinaz Yoshinaz merged commit e5d8f1e into main Dec 9, 2022
@Yoshinaz Yoshinaz deleted the samanun/eng-2054-make-consumer-in-kp-lib-public branch December 9, 2022 03:17
@github-actions
Copy link
Contributor
github-actions bot commented Dec 9, 2022

🎉 This PR is included in version 1.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poom poom poom approved these changes

@maetolay maetolay maetolay approved these changes

@tanadolw tanadolw Awaiting requested review from tanadolw tanadolw is a code owner automatically assigned from honestbank/backend-engineers

@cyberhck cyberhck Awaiting requested review from cyberhck

Assignees
No one assigned
Labels
released size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yoshinaz @poom @cyberhck @maetolay
0