[ADDED] Unit test for SearchParams
#415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a comprehensive suite of unit tests for the SearchParams.toQuery() method to ensure correct query formatting and URL encoding across various parameter combinations.
- Introduces tests covering all parameter combinations (required only, author only, reviewer only, and both)
- Verifies date range formatting and full URL encoding behavior
- Uses a private
encode()extension for readability in tests
Files not reviewed (1)
- .idea/kotlinc.xml: Language not supported
Comments suppressed due to low confidence (2)
src/test/kotlin/dev/hossain/githubstats/service/SearchParamsTest.kt:6
- [nitpick] Consider using a single assertion library (e.g.,
org.junit.jupiter.api.Assertions.assertTrue) instead of mixing JUnit and kotlin.test in one class for consistency.
import kotlin.test.assertTrue
src/test/kotlin/dev/hossain/githubstats/service/SearchParamsTest.kt:27
- [nitpick] The tests build expected queries via repetitive string concatenation and inline
encode()calls. Extract the parts into a list and usejoinToString("+")after mappingencode()to reduce duplication and improve readability.
"${\"is:closed\".encode()}+" +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the Kotlin plugin version and introduces comprehensive unit tests for the
SearchParamsclass to ensure proper functionality and encoding of query parameters.Kotlin Plugin Update:
.idea/kotlinc.xmlfrom2.1.0to2.1.21to align with the latest features and improvements.Unit Tests for
SearchParams:SearchParamsTest.ktwith the following tests to validate thetoQuerymethod: